RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

Julian Waters jwaters at openjdk.org
Mon Oct 10 11:59:56 UTC 2022


On Mon, 10 Oct 2022 05:06:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/java.base/share/native/libjli/jli_util.h line 91:
>> 
>>> 89:  * https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference
>>> 90:  * /snprintf-snprintf-snprintf-l-snwprintf-snwprintf-l?view=msvc-170
>>> 91:  */
>> 
>> I don't think the comment about the *lack* of a workaround is needed, just adding clutter.  But this isn't code I have much involvement with.  Other than that, the change looks fine.
>
> I agree, we don't document the absence of a workaround.

Removed the comment as requested

-------------

PR: https://git.openjdk.org/jdk/pull/10625


More information about the core-libs-dev mailing list