RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v3]
David Holmes
dholmes at openjdk.org
Tue Oct 11 02:03:25 UTC 2022
On Mon, 10 Oct 2022 11:59:55 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> The C99 snprintf is available with Visual Studio 2015 and above, alongside Windows 10 and the UCRT, and is no longer identical to the outdated Windows _snprintf. Since support for the Visual C++ 2017 compiler was removed a while ago, we can now safely remove the compatibility workaround on Windows and have JLI_Snprintf simply delegate to snprintf.
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Comment documenting change isn't required
> - Merge branch 'openjdk:master' into patch-1
> - Comment formatting
> - Remove Windows specific JLI_Snprintf implementation
> - Remove Windows JLI_Snprintf definition
Looks good. Thanks.
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10625
More information about the core-libs-dev
mailing list