RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v2]

Naoto Sato naoto at openjdk.org
Wed Oct 12 16:14:28 UTC 2022


On Mon, 10 Oct 2022 23:23:00 GMT, Bill Huang <bhuang at openjdk.org> wrote:

>> The jarsigner and keytool are localized into English, German, Japanese and Simplified Chinese. This task is to modify the existing i18n tests to validate i18n compliance in these tools. 
>> 
>> In addition, this task also contains changes for manual test enhancement and simplification which originated from [JDK-8292663](https://bugs.openjdk.org/browse/JDK-8292663).
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments.

Looks much better now. A minor comment on the library.

test/lib/jdk/test/lib/TestUI.java line 30:

> 28: import java.awt.event.WindowEvent;
> 29: 
> 30: public class TestUI {

I would expect some class description for this library. Also, could the library name be more descriptive than "TestUI"?

-------------

PR: https://git.openjdk.org/jdk/pull/10635


More information about the core-libs-dev mailing list