RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set [v2]
Markus KARG
duke at openjdk.org
Sat Oct 15 13:21:01 UTC 2022
On Mon, 3 Oct 2022 05:54:31 GMT, Markus KARG <duke at openjdk.org> wrote:
>> This PR implements JDK-8294696.
>
> Markus KARG has updated the pull request incrementally with one additional commit since the last revision:
>
> Checking explicitly -1 instead of < 0
> > Isn't a test needed here which fails without but passes with the proposed change?
> I do not see such a _need_, as this is solely a performance improvement, not a fixed bug or added functionality. If the majority of this team wants to have such a test, then please clearly instruct me to write one. Thanks.
@AlanBateman WDYT? Is such a test mandatory to include this rather simple PR?
-------------
PR: https://git.openjdk.org/jdk/pull/10525
More information about the core-libs-dev
mailing list