RFR: 8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher [v9]
Brent Christian
bchristi at openjdk.org
Wed Oct 19 22:25:07 UTC 2022
On Tue, 18 Oct 2022 23:03:16 GMT, Justin Lu <duke at openjdk.org> wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of Basic, but I removed it as it was not used within the Basic unit tests
>>
>>
>> Original output on success
>> <img src="https://user-images.githubusercontent.com/67398801/195936541-bc90db50-8d03-47be-9c4f-95176b19a6a7.png" width="350" height="350">
>>
>>
>> New output on success
>> <img src="https://user-images.githubusercontent.com/67398801/195936558-f85f4d48-dae2-4c38-aa50-46ef47db3d89.png" width="350" height="450">
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> Additional cleanup and string formatting
test/jdk/java/util/Formatter/BasicTestLauncher.java line 90:
> 88: ProcessBuilder pb = ProcessTools.createTestJvm(JAVA_OPTS, TEST_CLASS);
> 89: pb.environment().put("TZ", timeZone);
> 90: Process process = pb.start();
Nit: indentation
test/jdk/java/util/Formatter/BasicTestLauncher.java line 102:
> 100: private static void CheckTest(OutputAnalyzer output){
> 101: output.shouldHaveExitValue(0)
> 102: .reportDiagnosticSummary();
Nit: indentation
-------------
PR: https://git.openjdk.org/jdk/pull/10715
More information about the core-libs-dev
mailing list