RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java

Justin Lu duke at openjdk.org
Wed Oct 19 23:01:00 UTC 2022


On Wed, 19 Oct 2022 22:27:27 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Issue: Resource bundle name does not follow proper naming conventions according to [getBundle method](https://docs.oracle.com/javase/8/docs/api/java/util/ResourceBundle.html#getBundle-java.lang.String-java.util.Locale-) for base name parameter
>> 
>> Fix: Modified bundle name to be a fully qualified class and added regression tests.
>
> test/jdk/javax/sql/testng/test/rowset/ValidateResourceBundleAccess.java line 53:
> 
>> 51:         // is found from the resource bundle
>> 52:         try {
>> 53:             jrs.getMetaData();
> 
> The test should fail if the execution of `getMetaData()` succeeds.

Good point, will make that change

-------------

PR: https://git.openjdk.org/jdk/pull/10612


More information about the core-libs-dev mailing list