RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v4]
Justin Lu
duke at openjdk.org
Fri Oct 21 17:35:26 UTC 2022
On Fri, 21 Oct 2022 01:13:31 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Run Validate_.java in othervm mode
>
> test/jdk/javax/sql/resourceBundleTests/ValidateGetBundle.java line 67:
>
>> 65: } catch (MissingResourceException mr) {
>> 66: if (expectBundle) {
>> 67: throw new RuntimeException(String.format("Error:%s%n", mr.getMessage()));
>
> Probably the message could be more descriptive than a simple "Error". Also, instead of `mr.getMessage()`, use the 2-arg constructor that takes `mr` as the "cause". That would be straightforward.
Made the change and passed exception directly to constructor
-------------
PR: https://git.openjdk.org/jdk/pull/10612
More information about the core-libs-dev
mailing list