RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java [v2]
Justin Lu
duke at openjdk.org
Mon Oct 31 17:50:47 UTC 2022
> Issue: Duplication of methods between Basic*.java test classes, due to auto generation by genBasic.sh
>
> Fix: Reorganize parts of Basic-X.java.template into base class in Basic.java. Toggled -nel flag for generation script (genBasic.sh) to remove excessive white space. Moved a previous direct change to BasicDateTime.java into the template.
>
> Note: Main files to look at are Basic.java and Basic-X.java.template, as the rest are a reflection of the auto generation
Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
Remove old ids hack, has no usage
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/10910/files
- new: https://git.openjdk.org/jdk/pull/10910/files/8611e5b9..1bb22a2d
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=10910&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=10910&range=00-01
Stats: 20 lines in 2 files changed: 0 ins; 20 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/10910.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/10910/head:pull/10910
PR: https://git.openjdk.org/jdk/pull/10910
More information about the core-libs-dev
mailing list