RFR: 8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform

KIRIYAMA Takuya duke at openjdk.org
Fri Sep 9 08:38:16 UTC 2022


Could you please review the JDK-8293579 bug fixes?

tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to give 
the launcher the character which is encoded by Windows API WideCharToMultiByte() 
from UNICODE "é"(0x00e9) as an argument. However, this test fails because the 
code point "é"(0x00e9) cannot be treated on Japanese Windows.

WideCharToMultiByte() encodes characters as Shift-JIS on Japanese Windows, but 
the code point "é"(0x00e9) does not exist in Shift-JIS, and it is replaced with 
"e"(0x0065) as substitute. Therefore, "é"(0x00e9) and "e"(0x0065) are compared 
in this test and judged to be different characters, and return as failed.

So, in the Japanese encoding("MS932", "SJIS"), the test should be modified to 
give a character such as "あ"(0x3042) as the launcher's argument instead of 
"é"(0x00e9).

-------------

Commit messages:
 - 8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform

Changes: https://git.openjdk.org/jdk/pull/10226/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10226&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8293579
  Stats: 14 lines in 1 file changed: 12 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/10226.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10226/head:pull/10226

PR: https://git.openjdk.org/jdk/pull/10226


More information about the core-libs-dev mailing list