RFR: 8293595: tstrings::any() is missing an overload

Julian Waters jwaters at openjdk.org
Fri Sep 9 13:48:45 UTC 2022


tstrings::any() has an overload for std::wstring (if required) but is missing the corresponding operator overload for std::string, leaving only the templated one as a fallback, which will expand into a std::wostringstream << std::string operation. This isn't particularly safe on Windows, considering that JDK-8292008 and JDK-8247283 have been recently merged, and can sporadically cause build failures. This change simply adds the missing overload with the appropriate format handling that jpackage expects from std::string. Also contains minor name changes to fit the rest of the parameter names in the other overloads.

-------------

Commit messages:
 - Rename remaining parameters
 - Missing overload in any()

Changes: https://git.openjdk.org/jdk/pull/10231/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10231&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8293595
  Stats: 11 lines in 1 file changed: 5 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/10231.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10231/head:pull/10231

PR: https://git.openjdk.org/jdk/pull/10231


More information about the core-libs-dev mailing list