RFR: 8290367: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property [v2]

Aleksei Efimov aefimov at openjdk.org
Mon Sep 12 12:31:43 UTC 2022


On Mon, 12 Sep 2022 12:06:07 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Aleksei Efimov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add run for the SP w/o value, formatting/wording updates
>
> test/jdk/com/sun/jndi/ldap/objects/RemoteLocationAttributeTest.java line 64:
> 
>> 62:         SocketAddress sockAddr = new InetSocketAddress(
>> 63:                 InetAddress.getLoopbackAddress(), 0);
>> 64:         serverSocket.bind(sockAddr);
> 
> Perhaps we should `close()` this `serverSocket` in a finally block to cleanly shutdown?

Good idea, thanks. Will add it to try-with-resources statement, like:
`try (serverSocket) {
`

-------------

PR: https://git.openjdk.org/jdk/pull/10228


More information about the core-libs-dev mailing list