RFR: 8293499: Provide jmod --compress option [v5]

Jaikiran Pai jpai at openjdk.org
Tue Sep 13 09:58:33 UTC 2022


On Tue, 13 Sep 2022 09:31:49 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> I have been looking into `make clean-images images` performance, and realized jmod keeps compressing files with default compression level. Tuning that toward lighter compression levels improves build performance considerably, without a heavy loss in *.jmod sizes. 
>> 
>> This PR allows JMOD to select the compression level. Follow-ups would use this in the build system, see #10214.
>> 
>> The interesting asymmetry against `jlink` is: `jlink` provides `--compress` option that only takes `2` for "ZIP compression". (Separately, we could argue if it would be beneficial to extend `--compress` to `jlink` as well, so to select the compression level there too.)
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More review comments

The latest state of this PR looks fine to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10213


More information about the core-libs-dev mailing list