RFR: 8215788: Clarify JarInputStream Manifest access [v2]

Lance Andersen lancea at openjdk.org
Wed Sep 14 10:39:44 UTC 2022


On Wed, 14 Sep 2022 02:22:17 GMT, Weijun Wang <weijun at openjdk.org> wrote:

> Only tiny comments for the last paragraph.

Thank you Max, I addressed the above
> 
> That said, I have some questions on the other parts of this file:
> 
>     1. In `getNextEntry`, the method spec says "If verification has been enabled, any invalid signature detected while positioning the stream for the next entry will result in an exception." What does this mean?

I don't know the history of this comment in the spec and on a quick scan of the code, I am not sure I know either.  As our signed JAR expert, I will defer to you (and Alan) if we should remove this or leave  for another time to address(which I would prefer if we are not removing the verbiage).

> 
>     2. In `getManifest`, the method spec says "or null if none". Do we need to say "if not found"?

I think we are OK given the changes to the class description.

-------------

PR: https://git.openjdk.org/jdk/pull/10045


More information about the core-libs-dev mailing list