RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]
Vladimir Kozlov
kvn at openjdk.org
Tue Sep 20 23:36:35 UTC 2022
On Fri, 2 Sep 2022 00:52:49 GMT, Smita Kamath <svkamath at openjdk.org> wrote:
>> 8289552: Make intrinsic conversions between bit representations of half precision values and floats
>
> Smita Kamath has updated the pull request incrementally with one additional commit since the last revision:
>
> Addressed review comments
Looking on `cpuinfo` on this machines I do see `f16c`.
Here is additional output from `jdk/test/whitebox/CPUInfoTest.java`:
WB.getCPUFeatures(): "(12 cores per cpu, 2 threads per core) family 25 model 1 stepping 1 microcode 0x1000065, cx8, cmov, fxsr, ht, mmx, 3dnowpref, sse, sse2, sse3, ssse3, sse4a, sse4.1, sse4.2, popcnt, lzcnt, tsc, avx, avx2, aes, erms, clmul, bmi1, bmi2, adx, sha, fma, vzeroupper, clflush, clflushopt, hv, rdtscp, rdpid, f16c"
CPUInfo.getAdditionalCPUInfo(): "(12 cores per cpu, 2 threads per core) family 25 model 1 stepping 1 microcode 0x1000065"
CPUInfo.getFeatures(): [cx8, cmov, fxsr, ht, mmx, 3dnowpref, sse, sse2, sse3, ssse3, sse4a, sse4.1, sse4.2, popcnt, lzcnt, tsc, avx, avx2, aes, erms, clmul, bmi1, bmi2, adx, sha, fma, vzeroupper, clflush, clflushopt, hv, rdtscp, rdpid, f16c]
Well-known CPU features: [avx512bw, avx512pf, avx512_vbmi, avx2, rdpid, clflush, avx512cd, avx512_vbmi2, aes, 3dnowpref, avx512_vpopcntdq, avx512f, sha, avx512_vnni, avx512_vpclmulqdq, avx, erms, fsrm, sse4a, mmx, gfni, lzcnt, clmul, sse, avx512_vaes, avx512dq, fma, rtm, vzeroupper, cx8, ht, tsc, tscinv, clwb, tscinvbit, cmov, clflushopt, rdtscp, hv, sse2, sse3, avx512er, avx512vl, sse4.1, sse4.2, bmi1, bmi2, adx, avx512_bitalg, popcnt, fxsr, ssse3]
Here is test location: `test/lib-test/jdk/test/whitebox/CPUInfoTest.java`
I think you need to add `f16c` to it.
I am still not sure why JVMCI tests failed. May be JVMCI also have a list of CPU features you need to update.
I also don't see GitHub Action testing on your branch.
-------------
PR: https://git.openjdk.org/jdk/pull/9781
More information about the core-libs-dev
mailing list