RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

[Magnus Ihse Bursie]

On Tue, 20 Sep 2022 12:35:58 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> I haven't built a JDK using the `--with-import-modules` to include the `javafx.*` modules in quite a while, but my recollection is that yes, that did cause the JavaFX modules to be loaded by the platform class loader. The following is defined in the [`build.properties`](https://github.com/openjdk/jfx/blob/master/modules/javafx.swing/make/build.properties#L32) file for the `javafx.swing` module (as well as all other JavaFX modules), which is used by the JDK build when using `--with-import-modules`:
>> 
>> 
>> classloader=ext
>> 
>> 
>> I would guess that `ext` (which used to stand for the extension class loader) is causing it be included in the list of modules that are loaded by the platform class loader, but that needs to be checked.
>
>> I haven't built a JDK using the `--with-import-modules` to include the `javafx.*` modules in quite a while, but my recollection is that yes, that did cause the JavaFX modules to be loaded by the platform class loader. The following is defined in the [`build.properties`](https://github.com/openjdk/jfx/blob/master/modules/javafx.swing/make/build.properties#L32) file for the `javafx.swing` module (as well as all other JavaFX modules), which is used by the JDK build when using `--with-import-modules`:
>> 
>> ```
>> classloader=ext
>> ```
> 
> Thanks for this. In make/common/Modules.gmk, ReadSingleImportMetaData is adding to PLATFORM_MODULES. So I think this needs to re-examined as there should be no reason to have imported modules mapped to the boot or platform class loaders now.

@AlanBateman While this particular issue was closed now, this is perhaps yet another indication that the "import modules" thing is causing problems, and should be removed now that it is not used anymore. I created [JDK-8294095](https://bugs.openjdk.org/browse/JDK-8294095) to explore this possibility.

-------------

PR: https://git.openjdk.org/jdk/pull/10328