RFR: 8215788: Clarify JarInputStream Manifest access [v11]

Lance Andersen lancea at openjdk.org
Wed Sep 21 11:42:50 UTC 2022


On Wed, 21 Sep 2022 09:23:31 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> > Assuming we are set with the other changes, did you want to add the following paragraph (or similar) at line 58 to make it clear that if the Manifest is not found, then the JarEntry attributes will not be available:
> 
> This is something the reader can read about in the Signed JAR section of the JAR file spec and I think it's too much to try to include in this section of JarInputStream. If there is a place for this in JarInputStream then it's probably in the method description of getNextJarEntry as that can talk about the properties of the JarEntry that it returns. You could separate that out to a separate issue if you want.

OK, we can deal with this separately.  I guess I was trying to articulate that if the Manifest is not found in beginning of the input stream, then you have no access to the attributes given this is unique to JarInputStream

-------------

PR: https://git.openjdk.org/jdk/pull/10045


More information about the core-libs-dev mailing list