RFR: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment [v5]
Naoto Sato
naoto at openjdk.org
Wed Sep 21 16:52:45 UTC 2022
On Wed, 21 Sep 2022 11:38:36 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:
>> I removed a section of via JDK_JAVA_OPTIONS because including main class is not allowed in the specification.
>> This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment variable. At this time, this test is mismatch with the specification.
>> I tried to test and get Passed on Japanese Windows environment.
>> Could you review this fix, please?
>
> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
>
> 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment
Looks good. Please restore the newline at the end before integrating the changes
test/jdk/tools/launcher/I18NArgTest.java line 152:
> 150: }
> 151: }
> 152: }
Nit: don't remove the newline at the end
-------------
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9389
More information about the core-libs-dev
mailing list