RFR: 8234262: Unmask SIGQUIT in a child process [v2]
David Holmes
dholmes at openjdk.org
Thu Sep 22 21:52:19 UTC 2022
On Wed, 21 Sep 2022 21:37:59 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Clear the signal mask of the child when launching with posix_spawn.
>>
>> SIGQUIT signals are handled on non-Java Threads by the VM.
>> For Java threads the signal mask blocks SIGQUIT.
>> The ProcessBuilder uses posix_spawn on all platforms to create new processes.
>> Without a specific request, the child process inherits the signal masks from the parent.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Test both with and without -Xrs
Not sure it makes any difference whether this happens in the initial spawn or in jspawnhelper. I agree it is nicer to not affect the calling thread/process at all. My concern is that unblocking all signals may have some unintended side-effect, versus just dealing with SIGQUIT i.e. take a minimalist approach.
-------------
PR: https://git.openjdk.org/jdk/pull/10379
More information about the core-libs-dev
mailing list