Integrated: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions

Aleksey Shipilev shade at openjdk.org
Fri Sep 23 09:07:49 UTC 2022


On Mon, 19 Sep 2022 10:25:50 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Reliably reproduces on x86-32 with FPU:
> 
> 
> $ CONF=linux-x86-server-fastdebug make test TEST=java/lang/Float/Binary16ConversionNaN.java TEST_VM_OPTS="-XX:UseAVX=0 -XX:UseSSE=0"
> ...
> Roundtrip failure on NaN value 7de2 got back 7fe2
> Roundtrip failure on NaN value fde2 got back ffe2
> 
> 
> Since there are many NaN values in FP16 -- basically any non-zero significand works, we should probably just relax the test a bit.
> 
> Attn @jddarcy ;)
> 
> Additional testing:
>  - [x] Linux x86_32 fastdebug, `-XX:UseAVX=0 -XX:UseSSE=0`, affected test now passes
>  - [x] Linux x86_32 fastdebug, `-XX:UseAVX=0 -XX:UseSSE=1`, affected test still passes
>  - [x]  Linux x86_64 fastdebug, affected test still passes

This pull request has now been integrated.

Changeset: 0b56b822
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/0b56b822436a0662170c11777ff0009b89a667eb
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions

Reviewed-by: darcy

-------------

PR: https://git.openjdk.org/jdk/pull/10333


More information about the core-libs-dev mailing list