RFR: 8234262: Unmask SIGQUIT in a child process [v3]

Vyom Tewari vtewari at openjdk.org
Sat Sep 24 05:42:21 UTC 2022


On Thu, 22 Sep 2022 22:41:21 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Clear the signal mask of the child when launching with posix_spawn.
>> 
>> SIGQUIT signals are handled on non-Java Threads by the VM.
>> For Java threads the signal mask blocks SIGQUIT.  
>> The ProcessBuilder uses posix_spawn on all platforms to create new processes.
>> Without a specific request, the child process inherits the signal masks from the parent.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move clearing of the signal mask to jspawnhelper so the launched
>   process gets a clear signal mask.

Looks OK to me.

test/jdk/java/lang/ProcessBuilder/UnblockSignals.java line 23:

> 21:  * questions.
> 22:  */
> 23: import java.lang.Process;

Do we explicitly need to import java.long.Process ?

-------------

Marked as reviewed by vtewari (Committer).

PR: https://git.openjdk.org/jdk/pull/10379


More information about the core-libs-dev mailing list