RFR: 8279283 - BufferedInputStream should override transferTo [v11]

Markus KARG duke at openjdk.org
Sun Sep 25 00:39:34 UTC 2022


On Thu, 22 Sep 2022 22:14:02 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Markus KARG has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - corrected copyright
>>  - testing transferTo() after reset()
>
> test/jdk/java/io/BufferedInputStream/TransferTo.java line 40:
> 
>> 38: import java.nio.file.Files;
>> 39: import java.nio.file.Path;
>> 40: import java.nio.file.StandardOpenOption;
> 
> This import of `StandardOpenOption` is not needed due to line 55.

Done :-)

> test/jdk/java/io/BufferedInputStream/TransferTo.java line 89:
> 
>> 87: 
>> 88:         // tests empty input stream
>> 89:         assertThrows(NullPointerException.class, () -> inputStreamProvider.input().transferTo(null));
> 
> A number of code lines in the test are too long and make it even harder to read.

Done :-)

> test/jdk/java/io/BufferedInputStream/TransferTo.java line 162:
> 
>> 160:             out.write(new byte[posOut]);
>> 161: 
>> 162:             // fill buffer by reading some bytes before transformTo
> 
> transformTo -> transferTo

Done :-)

-------------

PR: https://git.openjdk.org/jdk/pull/6935


More information about the core-libs-dev mailing list