RFR: 8237467: effect of jlink plugins for vendor information and command-line options should be sticky [v2]

Doug Simon dnsimon at openjdk.org
Tue Sep 27 22:01:40 UTC 2022


> This PR adds a new jlink plugin (`--save-jlink-argfiles=<filenames>`) to support persisting jlink options.
> 
> 
>> echo "--add-modules jdk.internal.vm.ci --add-options=-Dfoo=xyzzy --vendor-version="XyzzyVM 3.14.15" --vendor-bug-url=https://bugs.xyzzy.com/" > my_image.argfile
>> export ALL_MODULES=$(java --list-modules | sed 's:@.*::g' | tr '\n' ',')
>> jlink --keep-packaged-modules=my_image/jmods --add-modules $ALL_MODULES --output=my_image --save-jlink-argfiles my_image.argfile
>> my_image/bin/java -XshowSettings:properties --version 2>&1 | grep yzzy
>> my_image/bin/jlink --add-modules=java.base --output=my_image2
>> my_image2/bin/java -XshowSettings:properties --version 2>&1 | grep yzzy
>     foo = xyzzy
>     java.vendor.url.bug = https://bugs.xyzzy.com/
>     java.vendor.version = XyzzyVM 3.14.15
> OpenJDK Runtime Environment XyzzyVM 3.14.15 (build 20-internal-2022-09-22-0951036.dnsimon...)
> OpenJDK 64-Bit Server VM XyzzyVM 3.14.15 (build 20-internal-2022-09-22-0951036.dnsimon..., mixed mode)
>> my_image2/bin/java -d jdk.internal.vm.ci | head -1
> jdk.internal.vm.ci at 20-internal

Doug Simon has updated the pull request incrementally with one additional commit since the last revision:

  changes to address review feedback

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10445/files
  - new: https://git.openjdk.org/jdk/pull/10445/files/583981a7..9502cd75

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10445&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10445&range=00-01

  Stats: 47 lines in 5 files changed: 9 ins; 22 del; 16 mod
  Patch: https://git.openjdk.org/jdk/pull/10445.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10445/head:pull/10445

PR: https://git.openjdk.org/jdk/pull/10445


More information about the core-libs-dev mailing list