RFR: 8065554: MatchResult should provide values of named-capturing groups [v7]

Stuart Marks smarks at openjdk.org
Wed Sep 28 04:13:25 UTC 2022


On Thu, 22 Sep 2022 10:22:40 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8065554: MatchResult should provide values of named-capturing groups

OK I took another look at everything and I think this is good to integrate.

The tests seem adequate but it seems like they would benefit from some refactoring. It might be an interesting exercise to revisit them and try out the new JUnit 5 APIs.

-------------

Marked as reviewed by smarks (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10000


More information about the core-libs-dev mailing list