RFR: 8178355: IdentityHashMap uses identity-based comparison for values everywhere except remove(K,V) and replace(K,V,V) [v4]

Stuart Marks smarks at openjdk.org
Wed Sep 28 15:55:34 UTC 2022


On Fri, 6 May 2022 22:05:35 GMT, liach <duke at openjdk.org> wrote:

>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare values by identity. Updated API documentation of these two methods ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Object,java.lang.Object))) to mention such behavior.
>
> liach has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Move tests
>  - Merge branch 'master' into fix/identityhashmap-default
>  - Fix assertions
>  - Revamp test and changes. Let ci run the tests
>  - Fix indent
>  - 8178355: IdentityHashMap uses identity-based comparison for values everywhere except remove(K,V) and replace(K,V,V)

I swear, I'll get to this soon! I even pulled over the patch and started looking at it.

@liach Actually one thing that would be helpful would if you could merge a recent master into the PR branch. Thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/8259


More information about the core-libs-dev mailing list