RFR: 8178355: IdentityHashMap uses identity-based comparison for values everywhere except remove(K,V) and replace(K,V,V) [v5]

liach duke at openjdk.org
Wed Sep 28 16:22:42 UTC 2022


> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare values by identity. Updated API documentation of these two methods ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Object,java.lang.Object))) to mention such behavior.

liach has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - Merge branch 'master' of https://git.openjdk.java.net/jdk into fix/identityhashmap-default
 - Move tests
 - Merge branch 'master' into fix/identityhashmap-default
 - Fix assertions
 - Revamp test and changes. Let ci run the tests
 - Fix indent
 - 8178355: IdentityHashMap uses identity-based comparison for values everywhere except remove(K,V) and replace(K,V,V)

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/8259/files
  - new: https://git.openjdk.org/jdk/pull/8259/files/c8468ce2..fc2218f0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=8259&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=8259&range=03-04

  Stats: 666861 lines in 8714 files changed: 393567 ins; 204685 del; 68609 mod
  Patch: https://git.openjdk.org/jdk/pull/8259.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/8259/head:pull/8259

PR: https://git.openjdk.org/jdk/pull/8259


More information about the core-libs-dev mailing list