RFR: 8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform [v2]

[Alexey Semenyuk]

On Thu, 29 Sep 2022 08:04:07 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

>> test/jdk/tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java line 55:
>> 
>>> 53:         String encoding = System.getProperty("native.encoding");
>>> 54:         switch (encoding) {
>>> 55:         default:
>> 
>> What I meant by the previous comment was to replace this `default` clause to:
>> 
>>     case "Cp1252", "UTF-8" -> testString = new String(Character.toChars(0x00E9));
>> 
>> And for other unknown encodings:
>> 
>>     default -> {
>>         System.out.println("Test skipped"); // or better message
>>         return;
>>     }
>> 
>> And your fix:
>> 
>>     case "MS932", "SJIS" -> testString = new String(Character.toChars(0x3042));
>> 
>> This way only the encodings that are guaranteed to succeed are tested.
>
> I am sorry to misunderstand your comment. 
> 
> I don’t know whether "é"(0x00e9) exists only in "Cp1252", "UTF-8".
> Will that be no problem that this test is skipped in other encordings? If skipped, the pattern for its encording probably won't be added forever. I think the other pattern should be added when this test fails. However I will follow the policy of OpenJDK.

I agree skipping the test is not the best solution. Leaving a hint in the comments on how to fix the issue looks better alternative.

-------------

PR: https://git.openjdk.org/jdk/pull/10226