RFR: 8304846: Provide a shared utility to dump generated classes defined via Lookup API [v5]

Mandy Chung mchung at openjdk.org
Mon Apr 3 20:25:00 UTC 2023


On Mon, 3 Apr 2023 19:41:28 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> I see your point.   If it were a static counter for all dumpers,  multiple`.failed-xxx` dumped by a single dumper may not be in sequence if other dumpers have `.failed-xxx` class files.
>
> If the counter has to be per dumper, maybe it makes sense to push the logic that derives the file name into ClassFileDumper too. e.g. have a `dumpClass(name, Class<?>, bytes)` and `dumpFailed(name, bytes)`.

that's a good idea.  Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13182#discussion_r1156419811


More information about the core-libs-dev mailing list