RFR: 8305107: Emoji related binary properties in RegEx
Iris Clark
iris at openjdk.org
Tue Apr 4 01:54:14 UTC 2023
On Mon, 3 Apr 2023 22:58:30 GMT, Naoto Sato <naoto at openjdk.org> wrote:
> Introducing new regex constructs that match those 6 new Unicode Emoji properties implemented in the `Character` class (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been drafted.
Associated CSR also Reviewed.
test/jdk/java/util/regex/RegExTest.java line 3827:
> 3825: POSIX_ASCII.isCntrl(cp) != cntrl.reset(str).matches() ||
> 3826: POSIX_Unicode.isCntrl(cp) != cntrlU.reset(str).matches() ||
> 3827: (CONTROL == type) != cntrlP.reset(str).matches() ||
I think this line may have lost the intended alignment of the "!=".
-------------
Marked as reviewed by iris (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13314#pullrequestreview-1370046964
PR Review Comment: https://git.openjdk.org/jdk/pull/13314#discussion_r1156628640
More information about the core-libs-dev
mailing list