RFR: 8305538: Avoid redundant HashMap.containsKey call in ModuleDescriptor.Builder

Alan Bateman alanb at openjdk.org
Thu Apr 6 09:05:18 UTC 2023


On Tue, 4 Apr 2023 20:43:13 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> But now `requireServiceTypeName` is called unconditionally.

requireServiceTypeName(service) should only be called when using the API. The non-strict route is when parsing a module-info on the module path, the checks that the names are legal should not be done for that case.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13288#issuecomment-1498724800


More information about the core-libs-dev mailing list