RFR: 8304911: Use OperatingSystem enum in some modules [v3]
Andrey Turbanov
aturbanov at openjdk.org
Fri Apr 7 08:09:46 UTC 2023
On Wed, 5 Apr 2023 15:48:02 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> With the addition of `jdk.internal.util.OperatingSystem` references to the system property `os.name` can be replaced.
>> This PR exports jdk.internal.util to:
>> - java.prefs,
>> - java.security.jgss,
>> - java.smartcardio,
>> - jdk.charsets,
>> - jdk.net,
>> - jdk.zipfs
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Backout unneeded changes to module-info and default.policy.
> Fixup formatting.
src/java.prefs/share/classes/java/util/prefs/Preferences.java line 299:
> 297: String platformFactory = switch (OperatingSystem.current()) {
> 298: case WINDOWS -> "java.util.prefs.WindowsPreferencesFactory";
> 299: case MACOS -> "java.util.prefs.MacOSXPreferencesFactory";
Suggestion:
case MACOS -> "java.util.prefs.MacOSXPreferencesFactory";
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13335#discussion_r1160525650
More information about the core-libs-dev
mailing list