RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

Roger Riggs rriggs at openjdk.org
Fri Apr 7 14:43:50 UTC 2023


On Thu, 6 Apr 2023 22:44:52 GMT, Phil Race <prr at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unneeded qualified export from java.base to jdk.attach
>
> src/jdk.accessibility/windows/classes/com/sun/java/accessibility/internal/AccessBridge.java line 169:
> 
>> 167:         // Load the appropriate DLLs
>> 168:         boolean is32on64 = false;
>> 169:         if (Architecture.isX86()) {
> 
> This would be another coupling of java.desktop into java.base internals and I don't think it worth it.
> Particularly because this check is obsolete !
> It is a remnant of when accessbridge was an unbundled download so provided both 32 and 64 bit.
> We don't even have  the file it is looking for in the build - even if someone did a 32 bit build.
> Instead of making this change a bug should be filed to remove this code.

Reverting; filed [8305745](https://bugs.openjdk.org/browse/JDK-8305745)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1160748988


More information about the core-libs-dev mailing list