RFR: 8305486: Add split() variants that keep the delimiters to String and j.u.r.Pattern [v2]

Raffaello Giulietti rgiulietti at openjdk.org
Tue Apr 11 08:53:38 UTC 2023


On Mon, 10 Apr 2023 14:00:46 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8305486: Add split() variants that keep the delimiters to String and j.u.r.Pattern
>>   Restored original JavaDoc to existing methods.
>>   Replaced proposed parametrized split(*, boolean) methods with suggested splitWithDelimiters(*) variants.
>>   Adjusted tests accordingly.
>
> src/java.base/share/classes/java/lang/String.java line 3237:
> 
>> 3235:      * the array are in the order in which they occur in this string.  If the
>> 3236:      * expression does not match any part of the input then the resulting array
>> 3237:      * has just one element, namely this string.
> 
> This paragraph duplicates part of the next paragraph.

Right, removed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13305#discussion_r1162498928


More information about the core-libs-dev mailing list