Integrated: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries

Eirik Bjorsnos duke at openjdk.org
Wed Apr 12 21:47:47 UTC 2023


On Tue, 7 Mar 2023 07:46:25 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:

> ZipOutputStream currently writes directory entries using the DEFLATED compression method. This does not strictly comply with the APPNOTE.TXT specification and is also about 10x slower than using the STORED compression method.
> 
> Because of these concerns, `ZipOutputStream.putNextEntry` should be updated with an `@apiNote` recommending
> the use of the STORED compression method for directory entries.
> 
> Suggested CSR in the first comment.

This pull request has now been integrated.

Changeset: 425ef068
Author:    Eirik Bjorsnos <eirbjo at gmail.com>
Committer: Lance Andersen <lancea at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/425ef0685c584abec80454fbcccdcc6db6558f93
Stats:     16 lines in 1 file changed: 15 ins; 0 del; 1 mod

8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method  should be used when writing directory entries

Reviewed-by: lancea, alanb

-------------

PR: https://git.openjdk.org/jdk/pull/12899


More information about the core-libs-dev mailing list