RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v13]
Roger Riggs
rriggs at openjdk.org
Fri Apr 14 14:34:51 UTC 2023
On Wed, 12 Apr 2023 17:31:49 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
>> Note that `amd64` and `x86_64` in the build are represented by `X64`.
>> The value of the system property `os.arch` is unchanged.
>>
>> The API is similar to the jdk.internal.util.OperatingSystem enum created by #[12931](https://git.openjdk.org/jdk/pull/12931).
>> Uses in `java.base` and a few others are included but other modules will be done in separate PRs.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Fixed isPPC64().
> Consolidated switch cases in ArchTest.
> Moved mapping of build TARGET_OS and TARGET_CPU to the build
> to avoid multiple mappings in more than one place.
make/modules/java.base/gensrc/GensrcMisc.gmk line 72:
> 70: endif
> 71:
> 72: $(eval $(call SetupTextFileProcessing, BUILD_PLATFORMPROPERTIES_JAVA, \
@erikj79 Is there a better/good way to do these mappings, or select "local" variable names?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1166913016
More information about the core-libs-dev
mailing list