RFR: 8305762: FileInputStream and FileOutputStream implSpec should be corrected or removed [v2]

Brent Christian bchristi at openjdk.org
Fri Apr 14 22:27:29 UTC 2023


On Fri, 14 Apr 2023 07:57:20 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updates, per review comments
>
> src/java.base/share/classes/java/io/FileInputStream.java line 45:
> 
>> 43:  * @apiNote
>> 44:  * To release resources used by this stream {@link #close} should be called
>> 45:  * directly or by try-with-resources.
> 
> I wonder if we should re-word the API note at the same time. I think it would be more readable to start with "The close method should be called ...".

Sounds good to me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13437#discussion_r1167310827


More information about the core-libs-dev mailing list