RFR: 8306075: Micro-optimize Enum.hashCode [v4]

Roger Riggs rriggs at openjdk.org
Mon Apr 17 14:59:39 UTC 2023


On Mon, 17 Apr 2023 14:23:01 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> olivergillespie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix two typos
>
> src/java.base/share/classes/java/lang/Enum.java line 177:
> 
>> 175:      * HotSpot's identity hash code generation also never returns zero
>> 176:      * as the identity hash code. This makes zero a convenient marker
>> 177:      * for the un-initialized value for both {@link @Stable} and the lazy
> 
> I'm sorry, but `@Stable` won't work with `@link`. `@Stable` is not a class, interface, member name, etc. See https://docs.oracle.com/en/java/javase/20/docs/specs/javadoc/doc-comment-spec.html#references

The @implNote is more appropriate for an internal comment. It is not needed to be in the published javadoc; its only useful to someone viewing the source code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13491#discussion_r1168852243


More information about the core-libs-dev mailing list