RFR: 8266571: Sequenced Collections [v2]

Stuart Marks smarks at openjdk.org
Tue Apr 18 00:21:59 UTC 2023


On Sat, 25 Mar 2023 07:34:51 GMT, Rémi Forax <forax at openjdk.org> wrote:

>> Stuart Marks has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - More specification tweaks.
>>  - Add simple overrides to ArrayList.
>
> src/java.base/share/classes/java/util/ReverseOrderListView.java line 191:
> 
>> 189:         if (o == this)
>> 190:             return true;
>> 191:         if (!(o instanceof List))
> 
> should be `if (!(o instanceof List<?> list))`

This and similar code are copied from AbstractList. Instead of fiddling around with formatting, I will eventually refactor this into some common support class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/7387#discussion_r1169371895


More information about the core-libs-dev mailing list