RFR: 8303866: Allow ZipInputStream.readEnd to parse small Zip64 ZIP files [v2]

[Eirik Bjorsnos]

On Tue, 18 Apr 2023 18:19:20 GMT, Lance Andersen <lancea at openjdk.org> wrote:

> It would be useful to obtain the zip/jar in question to validate that your proposed patch addresses the issue as well as verifying if ZipfFile can be used to process the zip/jar as reading the long thread appears that ZipFile:getInputStream is fine.

The original input file to the Tomcat Migration tool is found here:

https://repo1.maven.org/maven2/org/apache/tomcat/embed/tomcat-embed-core/10.1.7/tomcat-embed-core-10.1.7.jar

I have tested reading this file using `ZipInputStream` in this PR branch and it processes the 8 byte data descriptors successfully.

> Do you know how the Zip in question is being created, is it via ApacheCommons and could there be an issue there?

The file is produced in the Tomcat Ant release targets. First, the `jar` target produces the file, followed by postprocessing by `bnd` for OSGi purposes. At this point the file is still not in ZIP64 mode. Finally, the `zip` task is used to update the jar file with some Graal releated files , and this is where the ZIP64 seems to be introduced. 

I might want to do some more investigation on the Ant side to see if this behavior could be improved.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12524#issuecomment-1513687801