RFR: 8305092: Improve Thread.sleep(millis, nanos) for sub-millisecond granularity [v3]
Aleksey Shipilev
shade at openjdk.org
Wed Apr 19 10:02:46 UTC 2023
On Wed, 19 Apr 2023 09:27:49 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> You might need to check that test/hotspot/jtreg/vmTestbase/nsk/jdwp/ThreadReference/OwnedMonitorsStackDepthInfo/ownedMonitorsStackDepthInfo001/ownedMonitorsStackDepthInfo001a.java is passing. I haven't tried your changes but I remember needing to change this test when doing experimental changes in this area.
Oh, so that test checks the owned monitors are in frames at particular stack depths! So my previous PR breaks that test because it makes a delegated call to `sleep` in `java.lang.Thread`: all actual offsets are off by one. New PR drops that delegation and the entirety of `vmTestbase/nsk/jdwp/ThreadReference` now passes.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13225#issuecomment-1514461529
More information about the core-libs-dev
mailing list