RFR: 8305092: Improve Thread.sleep(millis, nanos) for sub-millisecond granularity [v3]

Aleksey Shipilev shade at openjdk.org
Wed Apr 19 10:13:01 UTC 2023


On Wed, 19 Apr 2023 06:07:04 GMT, David Holmes <dholmes at openjdk.org> wrote:

> You seemed to have missed:
> 
> ```
> ./cpu/x86/rdtsc_x86.cpp:    JavaThread::current()->sleep(FT_SLEEP_MILLISECS);
> ./share/compiler/compileBroker.cpp:  sleep(DeoptimizeObjectsALotInterval);
> ```
> 
> so not sure how this is building ???

Should not code when tired, having only Mac M1 on my hands! Argh.

Fun fact: at least on Darwin, we get standard `sleep` in `CompileBroker` if we rename `JavaThread::sleep` to something else. I think we would need to fully qualify those uses to avoid this trap in future -- I'll do a separate PR for this.

Other comments should be addressed in the series of new commits.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13225#issuecomment-1514476031


More information about the core-libs-dev mailing list