RFR: 8305990: Stripping debug info of ASM 9.5 fails [v3]

ExE Boss duke at openjdk.org
Wed Apr 19 16:53:45 UTC 2023


On Wed, 19 Apr 2023 13:44:47 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Classfile API didn't handle transformations of class files version 50 and below correctly. 
>> 
>> Proposed fix have two parts: 
>> 1. Inflation of branch targets does not depend on StackMapTable attribute presence for class file version 50 and below. Alternative fallback implementation is provided. 
>> 2. StackMapTable attribute is not generated for class file versions below 50.
>> 
>> StackMapsTest is also extended to test this patch.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed ClassPrinterImpl

src/java.base/share/classes/jdk/internal/classfile/Opcode.java line 261:

> 259:         NEW_OBJECT, NEW_PRIMITIVE_ARRAY, NEW_REF_ARRAY, NEW_MULTI_ARRAY,
> 260:         TYPE_CHECK, ARRAY_LOAD, ARRAY_STORE, STACK, CONVERT, OPERATOR, CONSTANT,
> 261:         MONITOR, NOP, DISCONTINUED_JSR, DISCONTINUED_RET ;

**Nit:** extraneous space:
Suggestion:

        MONITOR, NOP, DISCONTINUED_JSR, DISCONTINUED_RET;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13478#discussion_r1171604873


More information about the core-libs-dev mailing list