RFR: 8266571: Sequenced Collections [v7]

Stuart Marks smarks at openjdk.org
Wed Apr 19 18:32:07 UTC 2023


On Wed, 19 Apr 2023 12:27:41 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Stuart Marks has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Remove unnecessary 'final' from a couple places.
>>  - Clarify ordering of Collection.addAll and Map.putAll; add links to
>>    encounter order.
>>  - Make constructors private for several reverse-ordered views.
>
> src/java.base/share/classes/java/util/NavigableSet.java line 361:
> 
>> 359:      * {@inheritDoc}
>> 360:      * <p>
>> 361:      * This method is equivalent to {@link #descendingSet descendingSet}.
> 
> Doesn't `{@link #descendingSet}` display as `descendingSet` already? The same pattern appears in other places.

It would display as `descendingSet()` with the empty parens for the arguments. Not a big deal in this case. If there were arguments, though, the parameter types would all be listed as well, adding considerable clutter. Out of habit I use the plain form consistently.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/7387#discussion_r1171716527


More information about the core-libs-dev mailing list