RFR: JDK-8077371: Binary files in JAXP test should be removed [v2]
Joe Wang
joehw at openjdk.org
Wed Apr 19 19:20:44 UTC 2023
On Wed, 19 Apr 2023 17:32:49 GMT, Mahendra Chhipa <mchhipa at openjdk.org> wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
>
> closed file handlers.
Looks good overall
test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 89:
> 87: }
> 88: if(!Files.exists(Path.of(filePath, jdkVersion+"t"+FILENAME_DURATION ))) {
> 89: DatatypeFactory dtf = DatatypeFactory.newInstance();
Probably share the factory rather than creating one in each loop and twice.
-------------
PR Review: https://git.openjdk.org/jdk/pull/13537#pullrequestreview-1392731286
PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1171758806
More information about the core-libs-dev
mailing list