RFR: 8303002: Reject packed structs from linker [v5]

Jorn Vernee jvernee at openjdk.org
Thu Apr 20 00:34:50 UTC 2023


On Tue, 18 Apr 2023 22:17:02 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - fix TestIllegalLink
>>  - Merge branch 'PR_21' into RejectPacked
>>  - Merge branch 'PR_21' into RejectPacked
>>  - add javadoc + fixes for trailing padding
>>  - fix check for padding. Add check for trailing padding too
>>  - Reject packed structs and structs with extra padding
>>  - Check byte order of layouts passed to linker
>
> src/java.base/share/classes/java/lang/foreign/Linker.java line 200:
> 
>> 198:  * </table></blockquote>
>> 199:  * <p>
>> 200:  * Due to limited ABI specification coverage, all the native linker implementations limit the function
> 
> `All the native linker implementations support function function descriptors that contain only so-called...`

So, just drop the 'Due to limited ABI specification coverage'? I guess it's not really needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13164#discussion_r1171968181


More information about the core-libs-dev mailing list