RFR: 8306031: Update IANA Language Subtag Registry to Version 2023-04-13 [v2]
Justin Lu
jlu at openjdk.org
Thu Apr 20 06:16:47 UTC 2023
On Wed, 19 Apr 2023 22:46:44 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Copyright
>
> make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java line 144:
>
>> 142: boolean foundInOther = false;
>> 143: final String finalPref = ","+preferred;
>> 144: final String inbtwnPref = ","+preferred+",";
>
> This could utilize regex?
Much better that way, fixed
> make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java line 146:
>
>> 144: final String inbtwnPref = ","+preferred+",";
>> 145: // Check if current pref exists inside a value for another pref
>> 146: List<StringBuilder> doublePrefs = initialLanguageMap.entrySet()
>
> `values()` fits here
fixed
> make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java line 150:
>
>> 148: e.getValue().toString().contains(inbtwnPref)))
>> 149: .map(Map.Entry::getValue)
>> 150: .collect(Collectors.toList());
>
> Can replace `collect()` with `toList()`
Changed this, as well as the other existing occurrence
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13501#discussion_r1172122929
PR Review Comment: https://git.openjdk.org/jdk/pull/13501#discussion_r1172123278
PR Review Comment: https://git.openjdk.org/jdk/pull/13501#discussion_r1172123190
More information about the core-libs-dev
mailing list