RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

Lance Andersen lancea at openjdk.org
Thu Apr 20 16:09:46 UTC 2023


On Thu, 20 Apr 2023 10:06:33 GMT, Mahendra Chhipa <mchhipa at openjdk.org> wrote:

>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented the review comment.

The original version of this test was validating serialization compatibility with previous releases.

The current changes seems to have removed that validation in the re-write of the test

One option is to convert the various *.ser files to a byte array and have the test write them out or read them from a stream to do the validation

-------------

Changes requested by lancea (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13537#pullrequestreview-1394332620


More information about the core-libs-dev mailing list