RFR: 8300543 Compiler Implementation for Pattern Matching for switch [v2]

Jan Lahoda jlahoda at openjdk.org
Thu Apr 20 17:11:09 UTC 2023


On Tue, 18 Apr 2023 14:31:46 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 1021:
>> 
>>> 1019:              *    on patterns in the chosen column, as described above
>>> 1020:              */
>>> 1021:             var grouppedPerRecordClass =
>> 
>> Suggestion:
>> 
>>             var groupedPerRecordClass =
>
> or `patternsByRecordClass`, or `groupByRecordClass` (the latter would be consistent with `groupByHash` which is used below)

Should be resolved by:
https://github.com/openjdk/jdk/pull/13074/commits/bb59254e409821c9b14287c73a35ebe2dd2cbda9

Thanks for the comment!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13074#discussion_r1172876875


More information about the core-libs-dev mailing list