RFR: 8303002: Reject packed structs from linker [v6]

Jorn Vernee jvernee at openjdk.org
Fri Apr 21 00:25:57 UTC 2023


On Thu, 20 Apr 2023 09:27:40 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - restrictions -> characteristics
>>  - polish pt. 2
>>  - polish wording
>>  - review comments
>
> Looks good.
> 
> One (optional, for future?) thing that came to mind, is that if we wanted to speed up the check we could compute whether a layout is canonical or not on construction (since for structs we already have to go through all the elements and check alignment).

@mcimadamore Thanks for the review!

I've created a CSR with the finalized javadoc here: https://bugs.openjdk.org/browse/JDK-8306631 Could you review that as well? TIA

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13164#issuecomment-1517090854


More information about the core-libs-dev mailing list