RFR: 8305093: Linker cache should not take layout names into account [v2]
Jorn Vernee
jvernee at openjdk.org
Fri Apr 21 01:03:57 UTC 2023
> Strip names from the function descriptors used in linkage requests. The names are not important for classification, and this will allow the cached MethodHandle/UpcallStubFactory to be shared across linkage request with the same structure, but with layouts that have different names.
>
> I also have another implementation that avoids copying all the layouts, and instead re-implemented equals and hashCode in the LinkRequest wrapper: https://github.com/openjdk/jdk/compare/pr/13079...JornVernee:jdk:NoNameCache But, this seems too complex. Linking code is not very performance sensitive, so I instead went with a simpler approach in this patch.
Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
use al instead of ValueLayout.ADDRESS
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/13562/files
- new: https://git.openjdk.org/jdk/pull/13562/files/6ff4607e..cc7c4ebf
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=13562&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=13562&range=00-01
Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/13562.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13562/head:pull/13562
PR: https://git.openjdk.org/jdk/pull/13562
More information about the core-libs-dev
mailing list