RFR: 8304836: Make MALLOC_MIN4 macro more robust [v2]

Brent Christian bchristi at openjdk.org
Fri Apr 21 16:43:43 UTC 2023


On Fri, 21 Apr 2023 16:22:02 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> The current macro assumes the argument is `jint` because all locations pass `jint`. However, this would not work if a wider type such as `jlong` is passed. Removing the `unsigned` cast and make the condition explicit would make the macro more robust.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/java.base/share/native/libjava/jni_util.c
>   
>   Co-authored-by: David Schlosnagle <schlosna at gmail.com>

Marked as reviewed by bchristi (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/13564#pullrequestreview-1396087410


More information about the core-libs-dev mailing list